Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow brake hold #34384

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Allow brake hold #34384

merged 3 commits into from
Jan 16, 2025

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Jan 15, 2025

Closes #33988

Check:

@jyoung8607
Copy link
Collaborator

At present, VW doesn't set brakeHoldActive at all, so your proposed change doesn't affect us.

For the future, I'm actually not sure what happens if the driver tries to engage while in auto hold. Unfortunately my Golf R is stored for the winter and my Tiguan doesn't have auto hold. I'll ask for a tester in #volkswagen.

leonunix pushed a commit to leonunix/openpilot that referenced this pull request Jan 15, 2025
Copy link

@jsegill jsegill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see it work for Toyota! Looks like it took removing a line from my PR. Wish I caught that!

@sshane sshane merged commit 37b4e61 into master Jan 16, 2025
15 of 16 checks passed
@sshane sshane deleted the brake-hold branch January 16, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to activate OP while brake hold active
3 participants